[Bug 753081] New: applemedia/avsample: Cleanup of CA layer is racy and crashes occasionally

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753081

            Bug ID: 753081
           Summary: applemedia/avsample: Cleanup of CA layer is racy and
                    crashes occasionally
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Mac OS
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: hfink at toolsonair.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Created attachment 308498
  --> https://bugzilla.gnome.org/attachment.cgi?id=308498&action=edit
applemedia/avsample: Fix racy cleanup of CA layer

The block that is dispatched async to the main thread assumed the wrapping
GstAvSampleVideoSink to be alive. However, at the time of the block execution
the GstObject instance that is deferenced to access the CA layer might already
be freed, which caused occasional crashes. Instead, we now only pass the
CoreAnimation layer that needs to be released to the block. We use __block to
make sure the block is not increasing the refcount of the CA layer again on its
own.

patch for above fix is attached

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.