[Bug 748390] validate: media-descriptor: remove duplicate conditions
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Fri Jul 31 15:40:42 PDT 2015
https://bugzilla.gnome.org/show_bug.cgi?id=748390
--- Comment #21 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
commit e25a6aaf78eb592315f4cc990f1bee0494420241
Author: Nicolas Dufresne <nicolas.dufresne at collabora.com>
Date: Fri Jul 31 10:49:00 2015 -0400
validate: media-descriptor: Fix reading seekable record
Casting the result of g_strmp0 to boolean won't make gboolean
value 0 or 1. We need proper 0 and 1 so we can use == comparision.
commit 8d477c6d930c3a7251a7fbdac5879d643639bf76
Author: Vineeth TM <vineeth.tm at samsung.com>
Date: Fri Jul 24 15:36:27 2015 +0900
validate: media-descriptor: handle proper return values
while comparing the media descriptor with --expected-results, the return
values are not being handled properly, which results in wrong comparision
https://bugzilla.gnome.org/show_bug.cgi?id=748390
commit bd5fb7be260dd8a38ae069c131fae48f688bb22a
Author: Nicolas Dufresne <nicolas.dufresne at collabora.com>
Date: Thu Jul 30 15:14:13 2015 -0400
validate: media-descriptor: Add comment before ignored return value
As stated in the bug, this comparison failing is not a critical
error, warning is enough. Add a comment so nobody thinks it's a
coding error.
https://bugzilla.gnome.org/review?bug=748390
commit 2a5ff3f3c8dbc0edd57c3d19a2963639a80b0056
Author: Vineeth TM <vineeth.tm at samsung.com>
Date: Wed Jul 22 16:32:06 2015 +0900
validate: media-descriptor: remove duplicate conditions
when comparing tags, two conditions in if an else if are same
the correct way is to first check if both are NULL and return.
changed the condition accordingly.
https://bugzilla.gnome.org/show_bug.cgi?id=748390
commit f020c41d41358af35da09ce5127c722df1d9845e
Author: Vineeth TM <vineeth.tm at samsung.com>
Date: Wed Jul 22 16:07:19 2015 +0900
validate: media-descriptor: fix trivial spelling mistakes
replace comparse_stream with compare_streams
https://bugzilla.gnome.org/show_bug.cgi?id=748390
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list