[Bug 750863] tests: dashdemux: added unit tests for parsing period element

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750863

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #305325|none                        |reviewed
             status|                            |

--- Comment #9 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 305325:
 --> (https://bugzilla.gnome.org/review?bug=750863&attachment=305325)

Looks generally good, but needs changing if the first two patches need changes

::: tests/check/elements/dash_mpd.c
@@ +354,3 @@
+  GstMpdClient *mpdclient = gst_mpd_client_new ();
+
+  ret = gst_mpd_parse (mpdclient, xml, (gint) strlen (xml));

Same comment about the gint here

@@ +360,3 @@
+  assert_equals_string (periodNode->id, "TestId");
+  assert_equals_int64 (periodNode->start,
+      (gint64) duration_to_ms (0, 1, 2, 12, 10, 20, 123));

and assert_equals_uint64() here

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.