[Bug 744209] rtspsrc: May stop sending keep alive due to buggy timeout in rtspconnection

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=744209

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #300392|none                        |needs-work
             status|                            |

--- Comment #10 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 300392:
 --> (https://bugzilla.gnome.org/review?bug=744209&attachment=300392)

::: gst-libs/gst/rtsp/gstrtspconnection.c
@@ +802,3 @@
+    } else {
+      GST_ERROR ("failed to connect: %s", error->message);
+      res = GST_RTSP_ETIMEOUT;

Should probably be a generic error, not a timeout in that second case.

@@ +912,3 @@
+    } else {
+      GST_ERROR ("failed to connect: %s", error->message);
+      res = GST_RTSP_ETIMEOUT;

Same here.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.