[Bug 745441] v4l2: use v4l2 capture device sequence counter and add frame loss detection

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Mar 2 05:55:20 PST 2015


https://bugzilla.gnome.org/show_bug.cgi?id=745441

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #298267|none                        |reviewed
             status|                            |

--- Comment #2 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 298267:
 --> (https://bugzilla.gnome.org/review?bug=745441&attachment=298267)

Do you plan on a patchset to actually do something with that ? Lost frame
should be signalled using GAP event. Note about patch submission that we don't
use Signed-off-by in this project. We do enforce bugzilla cross-reference, so
you last line should be this bug URI.

::: sys/v4l2/gstv4l2src.c
@@ -753,3 @@
-    GST_BUFFER_OFFSET (*buf) = v4l2src->offset++;
-    GST_BUFFER_OFFSET_END (*buf) = v4l2src->offset;
-  }

Is there a reason to move code around here ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list