[Bug 744090] mpegtsmux doesn't permit to add stream during play

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=744090

--- Comment #15 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
(In reply to Andreas Schuler from comment #14)
> Okay, first of all, there must went anything wrong. I used git format-patch.
> Looks like I uploaded the wrong file....sorry.
> 
> ::: gst/mpegtsmux/mpegtsmux.c
> @@ +748,3 @@
> +            if (!ret)
> +            {
> +                GST_ELEMENT_ERROR (mux, STREAM, MUX, ("Reading program map
> failed. Assuming default"), (NULL));
> 
> 
> Hmm....I copied it from the old functions. But it's a good time to think
> about this part of code. In my opinion, when the developer adds a program
> map, he want to generate more than one program. If this doesn't works, all
> video and audio streams are added to one program. Normally this stream is
> not usable as intendet and we should stop with a error because the user
> doesn't suppose to get a stream like this. 
> 
> But when we do this, maybee we don't need the following line in code:
> idx = DEFAULT_PROG_ID;

Imagine you are using this to record a live event, so erroring out because of a
human error (the program map wasn't properly set) would cause you to lose the
recording, while just posting a warning gives the choice for the application to
continue or abort. I believe being more resilient is usually better, the
'broken' mpegts can be fixed with remuxing into the desired format while
erroring out could make the content lost forever.

Anyway this is not part of the intent of your patch, so if you desire it to
remain posting an error I will make no objection on merging your work. The
discussion for error/warning here can be done as a separate issue.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.