[Bug 745192] matroskademux: V_MS-VFW-FOURCC streams have DTS instead of PTS

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745192

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #298269|none                        |needs-work
             status|                            |

--- Comment #21 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 298269:
 --> (https://bugzilla.gnome.org/review?bug=745192&attachment=298269)

Looks good, but please do the following cleanup :) Then I'll merge it

::: gst/matroska/matroska-mux.c
@@ +3411,3 @@
       GST_LOG_OBJECT (mux, "have video keyframe, ts=%" GST_TIME_FORMAT,
+          GST_TIME_ARGS (gst_matroska_track_get_buffer_timestamp
+              (collect_pad->track, buf)));

Instead of calling the function many, many times here... just store the
timestamp in some local variable :) Will make it easier to read the code.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.