[Bug 744763] gltransformation: Make all property into universal [0-1] coordinate

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=744763

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #298147|none                        |reviewed
             status|                            |

--- Comment #10 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 298147:
 --> (https://bugzilla.gnome.org/review?bug=744763&attachment=298147)

Only minor doc and style, I think it's good otherwise.

::: ext/gl/gstgltransformation.c
@@ +201,3 @@
+  g_object_class_install_property (gobject_class, PROP_PIVOT_X,
+      g_param_spec_float ("pivot-x", "X Pivot",
+          "Rotation pivot point X coordinate, where 0 is the center,"

Maybe "X coordinate of the rotation pivot point"

@@ +202,3 @@
+      g_param_spec_float ("pivot-x", "X Pivot",
+          "Rotation pivot point X coordinate, where 0 is the center,"
+          " -1 the lef +1 the right boarder and <-1, >1 outside.",

s/lef/left

@@ +208,3 @@
+  g_object_class_install_property (gobject_class, PROP_PIVOT_Y,
+      g_param_spec_float ("pivot-y", "Y Pivot",
+          "Rotation pivot point X coordinate, where 0 is the center,"

Y, and maybe rephrase to.

@@ +209,3 @@
+      g_param_spec_float ("pivot-y", "Y Pivot",
+          "Rotation pivot point X coordinate, where 0 is the center,"
+          " -1 the lef +1 the right boarder and <-1, >1 outside.",

Left

@@ +280,3 @@
   graphene_vec3_init (&up, 0.f, 1.f, 0.f);

+  // Translate into pivot origin

C style comment please (warning only once)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.