[Bug 745107] glimagesink: implement GstVideoOverlayCompositionMeta

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745107

Mingke Wang <mingke.wang at freescale.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mingke.wang at freescale.com

--- Comment #8 from Mingke Wang <mingke.wang at freescale.com> ---
I'm trying to implement the GST_CAPS_FEATURE_META_GST_VIDEO_OVERLAY_COMPOSITION
in another sink using G2D. 
I added features in static caps template, but besides the
GST_CAPS_FEATURE_META_GST_VIDEO_OVERLAY_COMPOSITION feature,
GST_CAPS_FEATURE_MEMORY_SYSTEM_MEMORY also need to be added, since
gstbasetextoverlay will use them both for feature negotiation. 
we need two structure in caps, one is without feature, and one contains
feature. if only has one structure with feature, somehow, element link will
failed.
following if may code clip in my static caps function:
--------------------------------------------------------------
  caps = gst_caps_new_empty ();
  for(i=0; i<CAPS_NUM; i++) {
    GstStructure *structure = gst_structure_from_string(caps_str[i], NULL);
    gst_caps_append_structure (caps, structure);
  }

  for(i=0; i<CAPS_NUM; i++) {
    GstStructure *structure = gst_structure_from_string(caps_str[i], NULL);
    gst_caps_append_structure (caps, structure);
    GstCapsFeatures *f =
        gst_caps_features_new(GST_CAPS_FEATURE_MEMORY_SYSTEM_MEMORY, NULL);
    gst_caps_features_add(f,
GST_CAPS_FEATURE_META_GST_VIDEO_OVERLAY_COMPOSITION);
    gst_caps_set_features(caps, i+CAPS_NUM, f);
  }
---------------------------------------------------------------

and now I can get GstVideoOverlayCompositionMeta in may sink.and got the meta
info like following:
Blending composition 0x71ac4cf8 with 1 rectangles onto video buffer 0x7290f0d8
(1920x1088, format 23)
rectangle 0 0x71aa7008: 833x53, format 12

but before all above can be work, we need change video-overlay-composition.c
and video-overlay-composition.h a little bit to export
GstVideoOverlayComposition and GstVideoOverlayRectangle structures, otherwise
we can't get compiled.
the patch is attached.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.