[Bug 742918] v4l2: Add decoder and converter element with RW device property

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=742918

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #294529|none                        |needs-work
             status|                            |

--- Comment #8 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 294529:
 --> (https://bugzilla.gnome.org/review?bug=742918&attachment=294529)

Except for the code duplication, this look ok. I'll give it a try to make sure
nothing breaks. Can you add bug reference to your commit message when
re-submitting.

::: sys/v4l2/gstv4l2object.c
@@ +414,3 @@
+  g_object_class_install_property (gobject_class, PROP_DEVICE,
+      g_param_spec_string ("device", "Device", "Device location",
+          NULL, G_PARAM_READABLE | G_PARAM_STATIC_STRINGS));

I don't like copy paste here, specially that we clearly need to improve the
description, which will have to be done twice.

Maybe add an argument to previous call or something ? Or just find a better way
?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.