[Bug 745455] dashdemux doesn't take the presentationTimeOffset into account.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745455

--- Comment #13 from Mathieu Duponchelle <mduponchelle1 at gmail.com> ---
(In reply to Thiago Sousa Santos from comment #6)
> Review of attachment 298287 [details] [review]:
> 
> ::: ext/dash/gstdashdemux.c
> @@ +604,2 @@
>      /* start playing from the first segment */
> +    gst_mpd_client_set_segment_index_for_all_streams (dashdemux->client, 1);
> 
> This would make all streams start from fragment at the second position. For
> dashdemux it should still start counting from 0 as usual. It can happen that
> the dash MPD uses a segment list and not a segment template and dashdemux
> doesn't know about that.
> 
> The fix here is to assume in gstmpdparser.c that the startNumber=1 as
> default and otherwise read the value from the xml. Currently the default is
> being set to 0.

Indeed, the code already *almost* followed the spec, except it only did set the
default value if the field was present, which was not completely productive,
that's fixed :) Also, my previous patch indeed skipped the first fragment,
which is why I thought the first timestamps started at 3.84 seconds, your
comment fixes that, thanks :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.