[Bug 745455] dashdemux doesn't take the presentationTimeOffset into account.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745455

--- Comment #15 from Mathieu Duponchelle <mduponchelle1 at gmail.com> ---
(In reply to Thiago Sousa Santos from comment #9)
> Review of attachment 298288 [details] [review]:
> 
> ::: gst-libs/gst/adaptivedemux/gstadaptivedemux.c
> @@ +745,3 @@
>      stream->segment = demux->segment;
> +    stream->segment.start = stream->segment.position = stream->segment.time
> =
> +        stream->fragment.timestamp;
> 
> There is some other magic in other part of adaptivedemux to take care of
> live streams start time to avoid delaying playback start for them.
> 
> I think just somehow doing "segment.start/.position += presentationOffset;"
> would be a good enough solution here. Perharps some deeper changes would be
> needed in adaptivedemux to expose this to subclasses.
> 
> Also, I don't think 'time' should change here. The stream-time should start
> from 0 anyway.

Indeed, the patch I thought I had submitted only modified the segment start and
position already, I updated it.

Thanks a lot for the review, I think we've got something correct now.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.