[Bug 745705] glfilter: GLBuffer pool may have two owners

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745705

--- Comment #3 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
GLMixer was also having similar issue. Except that since there should be
multiple upstream pool, caching on the mixer object is not right. The actual
copy pasted caching code was picking the downstream pool.

commit 2d5d2eabef8023fadb355ba286b0ff89eede8c83
Author: Nicolas Dufresne <nicolas.dufresne at collabora.com>
Date:   Fri Mar 6 20:11:00 2015 -0500

    glmixer: Don't share our downstream pool with upstream

    Pool cannot have multiple owner. This can lead to spurious
    pool was flushing error.

    https://bugzilla.gnome.org/show_bug.cgi?id=74570


commit 7a3b34de7922f6c05a15615292c1317adc86db03
Author: Nicolas Dufresne <nicolas.dufresne at collabora.com>
Date:   Thu Mar 5 16:28:36 2015 -0500

    glfilter: Don't chain downstream pool

    Chaining a downstream pool would lead to two owner of the same
    pool. In dynamic pipeline, if one owner is removed from the pipeline
    the pool will be stopped, and the rest of the pipeline will fail
    since the pool will now be flushing. Also fix proposed pool caching,
    filter->pool was never set, never unrefed.

    https://bugzilla.gnome.org/show_bug.cgi?id=745705

commit fb4d7694255206ceaa81d8e7ff2a6ee3aa08c19a
Author: Nicolas Dufresne <nicolas.dufresne at collabora.com>
Date:   Thu Mar 5 15:49:50 2015 -0500

    glimagesink: Only cache pool, don't manage it

    GLImage does not use any kind of internal pool. There was some
    remaining code and comment stating that it was managing the
    pool, and it was in fact setting the active state when doing
    to ready state.

    * Only create the pool if requested and in propose_allocation
    * Cache the pool to avoid reallocation on spurious reconfigure
    * Don't try to deactivate the pool (we don't own it)

    https://bugzilla.gnome.org/show_bug.cgi?id=745705

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.