[Bug 743758] osxaudiosrc supports only 44100 sample rate on iOS

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=743758

Arun Raghavan <arun at accosted.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #298928|none                        |reviewed
             status|                            |

--- Comment #31 from Arun Raghavan <arun at accosted.net> ---
Review of attachment 298928:
 --> (https://bugzilla.gnome.org/review?bug=743758&attachment=298928)

::: sys/osxaudio/gstosxcoreaudio.c
@@ +72,3 @@
+
+  /* Assume AudioUnitRemovePropertyListenerWithUserData will block
+   * until the last listener finishes, so core_audio remains valid. */

Can we confirm this assumption (which sounds reasonable), and if not, deal with
it however appropriate?

@@ +75,3 @@
+  core_audio = GST_CORE_AUDIO (inRefCon);
+  g_assert (inUnit == core_audio->audiounit);
+  parent = core_audio->osxbuf->parent;  /* osxbuf is our owner, no need to ref
it */

What is the function of the parent here?

@@ +151,3 @@
+      kAudioUnitProperty_AudioChannelLayout, _audio_unit_property_listener,
+      core_audio);
+  if (status) {

Not too important, but we check status != noErr in the rest of the code.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.