[Bug 620323] mpegaudioparse: Add support for LAME tags and adjust segments based on the padding information from it

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=620323

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #298715|none                        |reviewed
             status|                            |

--- Comment #17 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 298715:
 --> (https://bugzilla.gnome.org/review?bug=620323&attachment=298715)

::: gst/audioparsers/gstmpegaudioparse.c
@@ +1139,3 @@
+   * calculations, because otherwise, the base parser's duration would be set
+   * twice (here and in gst_mpeg_audio_parse_adjust_segment) */
+  if (((mp3parse->encoder_delay == 0) && (mp3parse->encoder_padding == 0)) ||
(mp3parse->rate != -1)) {

Maybe just have a single function that sets these things?

@@ +1501,3 @@
+    segment->start = delay_in_ns;
+    segment->stop = duration - padding_in_ns;
+    segment->duration = duration - delay_in_ns - padding_in_ns;

This should maybe also adjust the segment.time and segment.base. You want to
drop samples, but should the first non-dropped sample have running/stream time
0 or N?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.