[Bug 740236] New interleave2 based on GstAggregator and create GstAudioAggregator from audiomixer

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=740236

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #297471|none                        |reviewed
             status|                            |

--- Comment #51 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 297471:
 --> (https://bugzilla.gnome.org/review?bug=740236&attachment=297471)

::: gst/audiomixer/gstaudioaggregator.c
@@ +614,3 @@
   }

+  g_return_val_if_fail (info.channels > 0, FALSE);

Shouldn't gst_audio_info_from_caps() just fail for incomplete caps? The
channels field is not optional! And the code also looks like it would.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.