[Bug 740236] New interleave2 based on GstAggregator and create GstAudioAggregator from audiomixer

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=740236

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|Normal                      |High
             Status|NEW                         |NEEDINFO
           Severity|enhancement                 |critical

--- Comment #59 from Olivier Crête <olivier.crete at ocrete.ca> ---
(In reply to Sebastian Dröge (slomo) from comment #53)
> @@ +711,3 @@
> + */
> +static gboolean
> +gst_audio_aggregator_fill_buffer (GstAudioAggregator * aagg,
> 
> Please check this complete function against the current audiomixer code
> again :)
> 
> @@ +731,3 @@
> +
> +  if (!GST_BUFFER_PTS_IS_VALID (inbuf) ||
> +      aggpad->segment.format != GST_FORMAT_TIME) {
> 
> We should require properly timestamps input buffers

In live pipeline, it's convenient to be able to send out buffers with a
GST_CLOCK_TIME_NONE pts, to be mixed asap, for thing like sound events and
stuff.


> ::: gst/audiomixer/gstaudioaggregator.h
> @@ +161,3 @@
> +void
> +gst_audio_aggregator_set_sink_caps (GstAudioAggregator * aagg,
> +    GstAudioAggregatorPad * pad, GstCaps * caps);
> 
> Why should subclasses be able to set caps on the sinkpad?
> 
> ::: gst/audiomixer/gstaudiomixer.c
> @@ +393,2 @@
> +  if (ret)
> +    gst_audio_aggregator_set_sink_caps (aagg, GST_AUDIO_AGGREGATOR_PAD
> (pad),
> 
> Why? Shouldn't that just be the default behaviour for setcaps()?

The base class doesn't have a setcaps at all, it just lets the subclass handle
the caps event.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.