[Bug 679768] mpegaudioparse, baseparse: fix tag handling

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=679768

--- Comment #17 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 263181:
 --> (https://bugzilla.gnome.org/review?bug=679768&attachment=263181)

Step 1, updating the patch for Sebastian's comments.

::: libs/gst/base/gstbaseparse.c
@@ +2259,3 @@

+  /* Push pending events, including SEGMENT events */
+  gst_base_parse_push_events (parse);

It has to be after the call to gst_base_parse_update_bitrates()

@@ +4375,3 @@
   /* We only care about stream tags here */
   if (gst_tag_list_get_scope (taglist) != GST_TAG_SCOPE_STREAM)
+    return FALSE;

That's what returning false does.

@@ +4544,3 @@
+  GST_OBJECT_LOCK (parse);
+  if (tags)
+    GST_DEBUG_OBJECT (parse, "merging tags %" GST_PTR_FORMAT, tags);

No idea, it's what the encoder/decoder base classes do.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.