[Bug 746147] compositor: Don't convert or aggregate pads that are completely obscured by a higher zorder pad

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=746147

--- Comment #14 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
(In reply to Nirbheek Chauhan from comment #8)
> I originally wrote that function as (x,y) + (w x h), then tried
> GstVideoRectangle, but the if statement in those cases was harder to
> decipher than this one. In addition, all the CLAMP() calls would need to
> move into the function in that case, making it even uglier, and less likely
> that the function would be inlined by gcc. Now that I think about it, it
> might actually make sense to add an inline keyword to the function
> definition...

This is called once per negotiation, so inlining is really unimportant. Two
points or a point and a size is up to you of course, the point that you should
put them in a structure for readability still holds.

> 
> It was just personal preference, since the current check is very simple and
> obvious at a glance, but I can change it if you feel strongly about it. :)

It's simple and obvious now, but the natural next step is clear, we need a
proper rectangle list management, and render from list of rectangle.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.