[Bug 746249] aggregator: Add gap event support

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=746249

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #299670|none                        |reviewed
             status|                            |

--- Comment #5 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 299670:
 --> (https://bugzilla.gnome.org/review?bug=746249&attachment=299670)

A little unit test would be nice :)

::: gst-libs/gst/base/gstaggregator.c
@@ +933,3 @@
+      gapbuf = gst_buffer_new ();
+
+      GST_BUFFER_PTS (gapbuf) = pts;

You should set DTS = PTS I think.

@@ +938,3 @@
+      GST_BUFFER_FLAG_SET (gapbuf, GST_BUFFER_FLAG_DROPPABLE);
+
+      gapbuf = gst_buffer_new ();

Why do you think you should chain it this way? It might work and actually be a
nice solution but looks weird at first sight.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.