[Bug 728438] v4l2: Implement a v4l2 video encoder

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=728438

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #299793|none                        |needs-work
             status|                            |

--- Comment #38 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 299793:
 --> (https://bugzilla.gnome.org/review?bug=728438&attachment=299793)

The commit log is of wrong form, should be:

v4l2videoenc: ...

Long descriptions, this is needed here.

Bug URI

::: sys/v4l2/gstv4l2object.c
@@ +2868,3 @@
+      v4l2object->type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE ||
+      v4l2object->type == V4L2_BUF_TYPE_VIDEO_OUTPUT ||
+      v4l2object->type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) {

Please, remove the if, this covers all the buffer type we support.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.