[Bug 746617] opusenc: headers are never sent

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=746617

--- Comment #16 from Ilya Konstantinov <ilya.konstantinov at gmail.com> ---
Ohh, you think it might be *only* for RTP! (I misread it the other way around.)

So:
- if it's not only for RTP, then gst_audio_encoder_set_headers is right
- if it's only for RTP, then modify

   1) gst_opus_header_create_caps
   2) gst_opus_header_create_caps_from_headers

  to allow 'headers' argument to be NULL (or just eliminate this GList
completely).

Is opusenc intended for streams only, while e.g. file muxing is done by some
other element? That's why you refer to the headers as "in-stream"?

The comment in gstopusheader.c says:
  /* Opus streams in Ogg begin with two headers; the initial header (with
     most of the codec setup parameters) which is mandated by the Ogg
     bitstream spec.  The second header holds any comment fields. */

Isn't it more likely that in RTP you don't have to send headers in-stream,
since there's SDP? https://tools.ietf.org/html/draft-ietf-payload-rtp-opus-07
certainly seems to indicate that SDP is the place for information like whether
the Opus stream is stereo.

I'll wait for your feedback tomorrow, as I get the feeling you know this
subject much more intimately than I do.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.