[Bug 746617] opusenc: headers are never sent

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sun Mar 22 14:45:06 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=746617

--- Comment #18 from Ilya Konstantinov <ilya.konstantinov at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #17)
> opusenc already puts the headers into the caps, there's nothing to change
> there in that case :)

I think we should then eliminate the 'enc->headers' member since it's
misleading.

> opusenc is intended for general Opus encoding, anything "container" specific
> should be done there. E.g. in WebM/Matroska and Ogg the headers are taken
> from the caps and placed in special places in the Matroska/Ogg headers.

Right now GstRtpOpusPay gets its caps from props (rate, channels). Ideally:
 1) those props should be eliminated, and
 2) it should learn to parse the "streamheader" structure (from sink caps), and
configure its src caps purely from the Opus header. This will require
duplicating some parsing code from opusdec.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.


More information about the gstreamer-bugs mailing list