[Bug 736891] input-selector: Can't unblock after emitting a "block" signal

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=736891

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #290971|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 290971:
 --> (https://bugzilla.gnome.org/review?bug=736891&attachment=290971)

Seems almost ok, but please add some explanation in the commit message *why* it
is ok to drop the signal. (Nobody could've used it for anything different than
causing deadlocks)

::: plugins/elements/gstinputselector.c
@@ -960,3 @@
   GST_INPUT_SELECTOR_LOCK (sel);
-  /* wait or check for flushing */
-  if (gst_input_selector_wait (sel, selpad)) {

wait() actually *waited* for self->flushing or pad->flushing (or not blocking).
This changes behaviour I think

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.