[Bug 746632] dispmanx: surfaceless EGL context support broken

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Mar 23 03:19:38 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=746632

--- Comment #3 from Philippe Normand <phil at base-art.net> ---
(In reply to Sebastian Dröge (slomo) from comment #2)
> Review of attachment 300117 [details] [review]:
> 
> Looks almost good (some empty newlines too many in window_resize)
> 
> ::: gst-libs/gst/gl/egl/gstglcontext_egl.c
> @@ +399,1 @@
>      window_handle =
> 
> Why only if there is no external context? I assume you could have an
> external context but still want to show the window ;)

Hum ok, so I need a different condition then.
Basically I don't want to show the window if glimagesink has a signal handler
connected to the client-draw signal, but that's outside of the context scope.
Any suggestions? :)

Thanks for the review, I'll remove the empty lines.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list