[Bug 739868] rtpmanager: rtpjitterbuffer fixes and improvements

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=739868

--- Comment #26 from Miguel París Díaz <mparisdiaz at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #20)
> Review of attachment 290315 [details] [review]:
> 
> This looks correct to me. Adding the retransmissions to the jitter will make
> it wrong as the rtptime of the retransmissions will be very much in the past
> (we wanted to have that packet earlier already, right?) but the receive time
> was just now.
> 
> ::: gst/rtpmanager/gstrtpjitterbuffer.c
> @@ +2213,3 @@
>  
> +    if (G_LIKELY (gap > -(priv->rtx_delay_reorder))) {
> +      calculate_jitter (jitterbuffer, dts, rtptime);
> 
> This won't do the right thing if rtx_delay_reorder==-1 ("automatic"). In
> that case we would ignore all expected packets (gap==0) and also all packets
> that are one in the future from our expected packet. With
> rtx_delay_reorder==0 we would also ignore all expected packets.
> 
> Otherwise this check seems correct.

Done!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.