[Bug 746518] input-selector: eos is always forwarded, even from unselected pads

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=746518

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.5.1

--- Comment #10 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
commit ce663311e1f00df5117b0249931e4ac960123cb8
Author: Jan Alexander Steffens (heftig) <jsteffens at make.tv>
Date:   Mon Mar 23 13:05:30 2015 +0100

    input-selector: Fix waiting on EOS

    This apparently got broken by bc1ec4e. Since self->blocked is always
    FALSE, gst_input_selector_wait never actually waits.

    Using (!self->eos || self->blocked) && ... as the loop condition would
    be incorrect as well, because then the other call to the function in
    _chain would block until EOS, so the functions cannot be merged trivially.

    Since blocking is obsolete, gst_input_selector_wait will get removed
anyway.
    As such, just inline the loop.

    https://bugzilla.gnome.org/show_bug.cgi?id=746518

commit 150e8a5c972fde2275ce93e23402b29a59129a47
Author: Thiago Santos <thiagoss at osg.samsung.com>
Date:   Fri Mar 20 07:23:53 2015 -0300

    tests: input-selector: new tests for EOS handling

    3 new tests:

    1) Tests that a stream that is empty (just an EOS event)
       on inactive pad doesn't get through and tamper
       with the active pad that still has data

    2) Tests that a stream that is shorter than the active one
       (pushes EOS earlier) doesn't has its EOS pushed

    3) Tests that switching to an inactive stream that has received
       EOS will make input-selector push EOS

    https://bugzilla.gnome.org/show_bug.cgi?id=746518

commit 92d2351b2e97668e00d5d60bddf4123cf293fc9a
Author: Thiago Santos <thiagoss at osg.samsung.com>
Date:   Thu Mar 19 12:11:19 2015 +0000

    tests: selector: remove weird semicolons at the end of test functions

    Even though it works, it is not needed and seems more natural
    to not have semicolons at the end of function declarations

    https://bugzilla.gnome.org/show_bug.cgi?id=746518

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.