[Bug 746682] flvdemux: Don't create AAC/H264 caps without codec_data

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Mar 24 08:20:29 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=746682

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
It's not an error anymore and we just ignore packets before we have codec_data.

commit ac0141b6a0dbb30372d11501b413a61b06da8d38
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Tue Mar 24 16:18:53 2015 +0100

    flvdemux: Only set caps once if they don't change

    Previously we were setting new caps with the same content for every H264 or
    AAC codec_data we found in the stream, spamming everything and causing
    renegotiations.

commit c9b42951fefaeb4afbad2f84ff845375424f8bcb
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Tue Mar 24 12:46:19 2015 +0100

    flvdemux: Don't create AAC/H264 caps without codec_data

    Instead delay creating the caps until we read the codec_data from the
stream,
    or fail if we get normal data before the codec_data.

    AAC raw caps and H264 avc caps always need codec_data, setting caps on the
pad
    without them is going to make negotiation fail most of the time. Even if we
    later set new caps with the codec_data, that's usually going to be too
late.

    https://bugzilla.gnome.org/show_bug.cgi?id=746682

commit 5e88b532122bab23227a010b1ca9790c595fd780
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Tue Mar 24 15:39:22 2015 +0100

    flvdemux: Fix indention

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list