[Bug 635701] rtspsrc: seeking is broken

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=635701

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #300315|none                        |accepted-commit_now
             status|                            |

--- Comment #11 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 300315:
 --> (https://bugzilla.gnome.org/review?bug=635701&attachment=300315)

Seems correct.

For the PAUSED case this probably also behaves different depending on whether
the clock continues running in paused (system clock) or stays at the same
position (most audio clocks). What are exactly the symptoms with PAUSED, what
running times do we output and what would be expected at this point (clock_time
- base_time)?

::: gst-libs/gst/rtp/gstrtpbasedepayload.c
@@ +588,2 @@
   segment.time = priv->npt_start;
+  segment.position = 0;

Shouldn't position be pts? Not that this value matters much anyway ;)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.