[Bug 746834] v4l2sink: driver is not queried for minimum number of buffers when propose_allocation is not called

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=746834

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicolas.dufresne at collabora.
                   |                            |co.uk

--- Comment #6 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Let me explain. With v4l2 M2M decoder drivers, the value of
MIN_BUFFERS_FOR_CAPTURE will depend on the format and the first buffer passed
to the OUTPUT device. At this point the v4l2object is already open. With your
patch, this value will be set once, and never be updated.

Also, there is nothing that prevent a v4l2sink driver to require S_FMT to be
called in order to get the right value. For this reason, I think you should
simply read that value before activating the pool for the case it's not
activated yet (not proposed). To avoid code duplication, I would suggest to add
a method in v4l2object to update the value.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.