[Bug 746142] tests: Add unit test for alpha manipulation in video-converter

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Mar 26 15:41:05 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=746142

--- Comment #3 from Reynaldo H. Verdejo Pinochet <reynaldo at opendot.cl> ---
Comment on attachment 299301
  --> https://bugzilla.gnome.org/attachment.cgi?id=299301
unit test case for alpha

> [...]
>+
>+  out_data = GST_VIDEO_FRAME_PLANE_DATA (&outframe, 0);
>+  out_bpp = GST_VIDEO_FRAME_COMP_PSTRIDE (&outframe, 0);
>+
>+#if G_BYTE_ORDER == G_LITTLE_ENDIAN

>From a quick glance at the code I'd suggest
ifdefing out_bpp += 3 on != G_LITTLE_ENDIAN
(or similar) once and drop all the other ifdefs.
Quite Shorter and a lot cleaner this way.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list