[Bug 728636] textoverlay: cuts off right edge italicised text

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=728636

--- Comment #9 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> ---
In the case of 0 offset, the code is trivially correct.

In the case of a positive offset, the ink spans "ink width", and starts at an
offset of "ink offset" from the textoverlay origin, so offset needs adding for
the "textoverlay width" to encompass all the ink (thre will be blank space on
the left of the ink, which gets counted in that "textoverlay width").

In the case of a negative offset, I'm not sure where the textoverlay origin is.
The code as it is would give us a clipped ink, so is still wrong, but I'd need
a test case to work out in what direction is needs extending to encompass the
extent of the ink. If the X offset from which textoverlay calculates its own
rectangle is shifted to the left in that case, then the "ink offset" should not
be added. But textoverlay does not seem to shift its own origin, otherwise we
would not have had that bug in the first place.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.