[Bug 745955] [gleffects] port all effects to GLES2

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745955

Julien Isorce <julien.isorce at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #300555|none                        |needs-work
             status|                            |

--- Comment #5 from Julien Isorce <julien.isorce at gmail.com> ---
Review of attachment 300555:
 --> (https://bugzilla.gnome.org/review?bug=745955&attachment=300555)

Thx for the updated patch. I put some new remarks since it breaks build when
only enabling gles2: ./configure --disable-glx --enable-egl --disable-opengl
--enable-gles2

::: ext/gl/effects/gstgleffectssources.c
@@ +125,2 @@
 /* Stretch Effect */
+#if GST_GL_HAVE_OPENGL

Do not had this guard, it breaks compilation when only enabling gles2.

@@ +665,3 @@
+  "  vec4 basecolor = texture2D (base, v_texcoord.xy);"
+  "  vec4 blendcolor = texture2D (blend, v_texcoord.xy);"
+    //"  gl_FragColor = basecolor * 0.5 + blendcolor * 0.5;"

Remove testing line.

::: ext/gl/effects/gstgleffectssources.h
@@ +24,1 @@
 #if GST_GL_HAVE_OPENGL

Remve this guard, it fine to compile both all the time, it was the case before
already.

::: ext/gl/gstgleffects.c
@@ +237,3 @@
+            "cannot change effect type"), ("%s",
+            "the current OpenGL context does not support the GL API
required"));
+    return;

Just remove this block since all effects are supported by all api now.

@@ +258,3 @@
+    case GST_GL_EFFECT_GLOW:
+      break;
+

Just remove this block.

@@ +261,3 @@
     default:
       g_assert_not_reached ();
   }

Move assert to previous switch since it handles all effects now.

@@ +491,3 @@
+    const gchar * shader_id, const gchar * shader_name,
+    const gchar * shader_source_gles2, const gchar * shader_source_opengl)
+{

Squash shader_id and shader_name. Having the 2 sources (opengl/gles2) is fine
if more customization.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.