[Bug 733827] v4l2videodec: Add pixel format negotiation support

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Mar 30 08:48:35 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=733827

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #300587|none                        |needs-work
             status|                            |

--- Comment #15 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 300587:
 --> (https://bugzilla.gnome.org/review?bug=733827&attachment=300587)

::: sys/v4l2/gstv4l2videodec.c
@@ +548,3 @@
+    if (!gst_v4l2_object_set_format (self->v4l2capture, caps)) {
+        gst_caps_unref (caps);
+        goto not_negotiated;

Somehow this change have to be wrong, if acquire_format() didn't fail, we
should never fail here. I suggest to start brainstorming on a design (which I
haven't had time to think of yet).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list