[Bug 654972] [rtmpsrc] "permission denied" error from rtmp not recognized

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=654972

Ilya Konstantinov <ilya.konstantinov at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #192310|none                        |needs-work
             status|                            |

--- Comment #3 from Ilya Konstantinov <ilya.konstantinov at gmail.com> ---
Review of attachment 192310:
 --> (https://bugzilla.gnome.org/review?bug=654972&attachment=192310)

The patch is pretty obvious but I'd go without the whitespace changes.

::: ext/rtmp/gstrtmpsrc.h
@@ +35,1 @@
 G_BEGIN_DECLS

No need to change whitespace.

@@ +44,3 @@
 #define GST_IS_RTMP_SRC_CLASS(klass) \
   (G_TYPE_CHECK_CLASS_TYPE((klass),GST_TYPE_RTMP_SRC))
+typedef struct _GstRTMPSrc GstRTMPSrc;

No need to change whitespace.

@@ +58,1 @@
   /* < private > */

No need to change whitespace.

@@ +73,3 @@
 struct _GstRTMPSrcClass
 {
+  GstPushSrcClass parent;

No need to change whitespace.

@@ +80,1 @@
 G_END_DECLS

No need to change whitespace.

@@ +81,1 @@
 #endif /* __GST_RTMP_SRC_H__ */

No need to change whitespace.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.