[Bug 747126] androidmedia: add support for more color formats

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747126

--- Comment #8 from Matthieu Bouron <matthieu.bouron at collabora.com> ---
(In reply to Sebastian Dröge (slomo) from comment #6)
> Comment on attachment 302636 [details] [review]
> androidmedia: Declare QOMX_COLOR_FORMATYVU420PackedSemiPlanar32mMultiView
> constant
> 
> What's the point of adding this constant but not using it?

So we know what its value stands for as it is not part of the documentation and
I had trouble finding what it was meaning. It is reported by my nexus5 device
(android 5.1).


(In reply to Sebastian Dröge (slomo) from comment #7)
> Comment on attachment 302807 [details] [review]
> androidmedia: Add support for COLOR_FormatYV12
> 
> YV12 is in YVU order, not YUV. So not exactly the same as I420 and the
> others. You might need to swap the planes.

It is covered under the same case as COLOR_FormatYUV420Planar and
COLOR_FormatYUV420Flexible to compute the frame_size and it is mapped to
GST_VIDEO_FORMAT_YV12 in color_format_mapping_table[]. Isn't it enough ?
I'm not a huge fan at sending this kind of patch without testing but I don't
have the relevant device.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.