[Bug 748946] videoaggregator: add "aggregate-eos" property to input pads to ignore EOS

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=748946

--- Comment #2 from Nirbheek Chauhan <nirbheek.chauhan at gmail.com> ---
(In reply to Tim-Philipp Müller from comment #1)
> I know no one expected this, but I think we can probably find a better /
> more concise name for this property ;)
> 
> How about just "ignore-eos"? This doesn't convey the fact that we will still
> EOS if all the non-ignore pads are EOS (we will, won't we?), but at least
> it's clear what it does if you set it.

I like "ignore-eos". More concise and a better description of what will happen.
:) I'll wait a day for more suggestions and then attach a patch with that
change.

However, we will *not* EOS if all the non-ignore pads are EOS. videoaggregator
only forwards EOS when all the pads are EOS, so if one of the pads will never
go EOS (because we set "ignore-eos"), videoaggregator will not go EOS till that
pad is removed.

I think this behaviour is actually a feature and is consistent with how the
element already behaves. Besides that, I think it would be annoying to have to
add a pad probe to every non-ignore-eos pad and catch the EOS there to avoid
the element going EOS despite asking that it not go EOS till all the
"ignore-eos" pads are removed (or the property flipped).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.