[Bug 749104] video-converter: Change some implicit string enums to real enums

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749104

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #303071|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 303071:
 --> (https://bugzilla.gnome.org/review?bug=749104&attachment=303071)

Looks generally good, just some doc cleanup needed

::: gst-libs/gst/video/video-converter.h
@@ +157,3 @@
  * GST_VIDEO_CONVERTER_OPT_ALPHA_MODE:
  *
+ * #G_TYPE_ENUM, the alpha mode to use.

GST_TYPE_VIDEO_ALPHA_MODE

@@ +168,3 @@
  *         #GST_VIDEO_CONVERTER_OPT_ALPHA_VALUE
  *
+ * Default to "copy".

Shouldn't explain all the values as strings but just refer to the docs of the
enum

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.