[Bug 738237] baseparse: parser is never marked as FLAG_LOST_SYNC on discont

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=738237

--- Comment #11 from Mark Nauwelaerts <mnauw at users.sourceforge.net> ---
Afaik it should still hold lost_sync == !(in sync) == discont.  As such, it
should probably be set on start, and whenever the subclass decides to skip some
bytes (representing a discontinuity).

There may well have been some glitching causing it not to be set properly. 
Unfortunately, baseparse (code) is not always the clearest and cleanest, and it
could well do with some re-writing (and tweaked ABI/semantics), but that's
another one ...

So, afaics, the patch looks ok, and so does wavpackparse, and there's
reasonable chance there is some problem with the unit test.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.