[Bug 749122] vp8enc: target bitrate is not working as expected

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749122

--- Comment #20 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Ok, there was something very stupid. Fixed that now ;) See newly attached
patch. Does this work for you now (with these two patches, but not the one from
comment 5)?

These two are pushed now:
commit a0b69c8dac4fed558845b3251105395ae94b8059
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Tue May 12 12:13:16 2015 +0300

    vp[89]enc: Properly convert between GStreamer and encoder timebase

    ... by switching numerator and denominator when scaling.

    https://bugzilla.gnome.org/show_bug.cgi?id=749122

commit eb365cc3bb9361469ce11f7fe99f26c892b0663e
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Mon May 11 13:33:26 2015 +0300

    vp[89]enc: Don't set timebase from the framerate

    The framerate very often is just an indication of the ideal framerate, not
the
    actual framerate of the stream. By just using the framerate, we confuse the
    rate control algorithm algorithm as multiple frames will map to the same
PTS
    or have durations of 0.

    https://bugzilla.gnome.org/show_bug.cgi?id=749122

-- 
You are receiving this mail because:
You are the QA Contact for the bug.