[Bug 749258] Basesink: has issue when checking if buffers are too late before calling prepare/prepare_li

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749258

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #303252|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 303252:
 --> (https://bugzilla.gnome.org/review?bug=749258&attachment=303252)

I agree, your patch makes more sense.

::: libs/gst/base/gstbasesink.c
@@ +3367,3 @@
+        base_time = GST_ELEMENT_CAST (basesink)->base_time;
+        stime = base_time + gst_base_sink_adjust_time (basesink, rstart);
+        now = gst_clock_get_time (clock);

When accessing the clock and base time directly like this, you need to take the
object lock all the time.

@@ +3371,2 @@
           gst_base_sink_is_too_late (basesink, obj, rstart, rstop,
+              GST_CLOCK_EARLY, GST_CLOCK_DIFF (stime, now), FALSE);

Not sure if EARLY is always correct here... it might depend on whether
stime>now or not, no?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.