[Bug 749258] basesink: fix QoS/lateness checking if subclass implements prepare/prepare_list vfuncs

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749258

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.5.1

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Thanks! I just moved the lock a little bit before merging.

commit 4f79c5e8da516c137d4c9b0175ccb0a2ab147a6b
Author: Jian <Jian.Li at freescale.com>
Date:   Thu May 14 15:49:43 2015 +0800

    basesink: Fix QoS/lateness checking if subclass implements
prepare/prepare_list vfuncs

    In basesink functions gst_base_sink_chain_unlocked(), below code is used to
    checking if buffer is late before doing prepare call to save some effort:
        if (syncable && do_sync)
          late =
              gst_base_sink_is_too_late (basesink, obj, rstart, rstop,
              GST_CLOCK_EARLY, 0, FALSE);

        if (G_UNLIKELY (late))
          goto dropped;

    But this code has problem, it should calculate jitter based on current
media
    clock, rather than just passing 0. I found it will drop all the frames when
    rewind in slow speed, such as -2X.

    https://bugzilla.gnome.org/show_bug.cgi?id=749258

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.