[Bug 749378] New: oggmux: valgrind error when transcoding

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749378

            Bug ID: 749378
           Summary: oggmux: valgrind error when transcoding
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: gdesmott at gnome.org
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Running the 
validate.file.transcode.to_vorbis_and_theora_in_ogg.mp3_h264_0_mp4 scenario
inside valgrind raise this error:

==23014== Use of uninitialised value of size 8
==23014==    at 0x93300C1: ogg_page_checksum_set (framing.c:307)
==23014==    by 0x933041B: ogg_stream_flush_i (framing.c:515)
==23014==    by 0x8F01CFB: gst_ogg_mux_process_best_pad (gstoggmux.c:1704)
==23014==    by 0x8F01CFB: gst_ogg_mux_collected (gstoggmux.c:2042)
==23014==    by 0x57DE876: gst_collect_pads_check_collected
(gstcollectpads.c:1340)
==23014==    by 0x57E0068: gst_collect_pads_chain (gstcollectpads.c:2193)
==23014==    by 0x4C2B458: gst_validate_pad_monitor_chain_func
(gst-validate-pad-monitor.c:2009)
==23014==    by 0x5A6A503: gst_pad_chain_data_unchecked (gstpad.c:4038)
==23014==    by 0x5A6A503: gst_pad_push_data (gstpad.c:4271)
==23014==    by 0x8CB7F8E: gst_queue_push_one (gstqueue.c:1337)
==23014==    by 0x8CB7F8E: gst_queue_loop (gstqueue.c:1484)
==23014==    by 0x5A98EF0: gst_task_func (gsttask.c:331)
==23014==    by 0x3EBB070D67: g_thread_pool_thread_proxy (gthreadpool.c:307)
==23014==    by 0x3EBB0703D4: g_thread_proxy (gthread.c:764)
==23014==    by 0x3EB8807529: start_thread (pthread_create.c:310)
==23014==    by 0x3EB850022C: clone (clone.S:109)

I've done some digging and it looks like one of the ogg->body[i] accessed in
the ogg_page_checksum_set() function is not initialized.

This body array is directly computed using the ogg_stream_state we pass to
ogg_stream_flush() so this may be a bug in the way gst handles this memory.

  og->body=os->body_data+os->body_returned;

Another option could be that the computed size of this array (using the header)
is wrong.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.