[Bug 749445] [patchset] Fix capabilities verification and unit tests as result

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749445

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #303438|none                        |rejected
             status|                            |

--- Comment #10 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 303438:
 --> (https://bugzilla.gnome.org/review?bug=749445&attachment=303438)

::: gst/gststructure.c
@@ +3339,3 @@
 {
   if ((superset->name != subset->name) ||
+      (gst_structure_n_fields (superset) < gst_structure_n_fields (subset)))

This change is not correct. The superset has to contain less or equal fields
than the subset.

This is because if a field is missing, it is assumed that any possible value
for that field would be possible. So for every field that is in the (potential)
subset and not in the superset, the subset check would succeed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.