[Bug 749417] rtsp-client: add API to allow application to decide what requirements are supported

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749417

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #303408|none                        |needs-work
             status|                            |

--- Comment #4 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 303408
  --> https://bugzilla.gnome.org/attachment.cgi?id=303408
rtsp-client: allow application to decide what requirements are supported

>+  gst_rtsp_client_signals[SIGNAL_CHECK_REQUIREMENTS] =
>+      g_signal_new ("check-requirements", G_TYPE_FROM_CLASS (klass),
>+      G_SIGNAL_RUN_LAST, G_STRUCT_OFFSET (GstRTSPClientClass,
>+          check_requirements), NULL, NULL, g_cclosure_marshal_generic,
>+      G_TYPE_BOOLEAN, 1, G_TYPE_POINTER);

G_TYPE_POINTER is not something that should be used in public API. It won't
work with bindings, nor does anyone know what the type of the argument is.


>--- a/gst/rtsp-server/rtsp-client.h
>+++ b/gst/rtsp-server/rtsp-client.h
>@@ -126,6 +126,7 @@ struct _GstRTSPClientClass {
> 
>   void     (*announce_request)        (GstRTSPClient *client, GstRTSPContext *ctx);
>   void     (*record_request)          (GstRTSPClient *client, GstRTSPContext *ctx);
>+  void     (*check_requirements)      (GstRTSPClient *client, GstRTSPContext *ctx);
> 
>   /*< private >*/
>   gpointer _gst_reserved[GST_PADDING_LARGE-5];

If you add a vfunc you need to remove one pointer from the reserved array, i.e.
change this to GST_PADDING_LARGE-6.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.