[Bug 749531] xvimagesink: refactor code to remove unnecessary mutex lock/unlock

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749531

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |NOTABUG
   Target Milestone|git master                  |NONE

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
I think you misunderstood what this code does.

The prepare_window_handle() will post a message on the bus that gives the
application a chance to supply its own window handle. Applications might
intercept the message in a sync message handler and then call the
gst_video_overlay_set_window_handle().

The the whole point of this code is to first give the application a chance to
set its own window, and then in the second if() we create our own if we didn't
get one from the application.

Furthermore, prepare_window_handle() must be called with the lock UNLOCKED
otherwise we get a deadlock if application code calls one of our functions that
takes the lock again (like _set_window_handle).

Please re-open if I missed something though, thanks.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.