[Bug 747517] appsrc: negotiates twice if caps are changed before pipeline starts

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon May 18 05:44:17 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=747517

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.5.1

--- Comment #7 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Pushed this now:

commit 8304893d061d4a134ea87801b710dfb99ae15968
Author: Tim-Philipp Müller <tim at centricular.com>
Date:   Mon May 18 11:23:16 2015 +0100

    appsrc: optimise caps changing when previously-set caps have not taken
effect yet

    Only negotiate/change caps once when setting caps twice and
    the first-set caps have not been used yet.

    Based on patch by Eunhae Choi.

    https://bugzilla.gnome.org/show_bug.cgi?id=747517


I think your approach to check the queue's tail is better and more universal,
so I've taken that over, but fixed the unref. And removed the !started check
from my patch then.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list