[Bug 749574] New: audioaggregator: Deadlock in gst_object_sync_values()

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749574

            Bug ID: 749574
           Summary: audioaggregator: Deadlock in gst_object_sync_values()
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: nirbheek.chauhan at gmail.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Created attachment 303584
  --> https://bugzilla.gnome.org/attachment.cgi?id=303584&action=edit
An incorrect fix for the issue

audioaggregator calls gst_object_sync_values() inside
gst_audio_aggregator_fill_buffer() with the pad and aggregator locks taken.
This is incorrect since if there's any changes scheduled using GstController,
the sync_values call will deadlock while trying to make those changes (since
making those changes requires taking those locks).

The attached patch is completely wrong, but serves to show the location of the
issue. Ideally, fill_buffer() should be refactored to call sync_values() right
before taking the locks the same way that videoaggregator does.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.