[Bug 749581] rtpbasepayload: Try harder to reuse previously configured caps values and give more preference to anything set as properties

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749581

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.5.1

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
commit faafaaec56de31ebecf02b87e1fc0e4c07ed9ecc
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Tue May 19 16:32:38 2015 +0300

    rtpbasepayload: Try harder to reuse previously configured caps values and
give more preference to anything set as properties

    This affects the pt, ssrc, seqnum-offset and timestamp-offset properties.
If
    they were set from a property, or we configured caps before, we try to use
    that value for them. Even if the first structure of the downstream caps
    specifies a different value, we check if the value is supported by other
    structures.
    Only if all this fails, we use the values given by downstream in the first
    structure, i.e. if no properties were set and these are the first caps we
    negotiate or downstream does not support our values.

    By doing this we ensure that we don't spuriously change ssrcs or other
fields
    in the middle of the stream (and also consider property values more). Ssrc
    changes would currently happen after sending an RTX packet (thus creating a
    new internal source inside the rtpsession), and then renegotiating the
    payloader (which then gets the RTX ssrc from rtpsession).

    https://bugzilla.gnome.org/show_bug.cgi?id=749581

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.