[Bug 749684] New: Segfault when playback starts after refactor for segments iteration

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749684

            Bug ID: 749684
           Summary: Segfault when playback starts after refactor for
                    segments iteration
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: david.waring at rd.bbc.co.uk
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Created attachment 303761
  --> https://bugzilla.gnome.org/attachment.cgi?id=303761&action=edit
Fix segfault on live stream playback

Experiencing a segfaults in gstreamer when trying to playback the DASH stream
at:
http://dash.bidi.int.bbc.co.uk/e/pseudolive/bbb/client_manifest.mpd

The functions causing segfaults appear to be:
gst_mpd_client_get_next_fragment_timestamp
gst_mpd_client_get_next_fragment
gst_mpd_client_has_next_segment
gst_mpd_client_advance_segment

This appears to be cases in the code where stream->segments->len is used
without stream->segments being checked first. In other cases where this
attribute is used there is a separate case for when the segments attribute is
NULL.

This behaviour looks like it was introduced in commits 6344f86e "dashdemux:
improve mpd parsing for repeated segment entries" and 2105a310 "dashdemux:
refactor segment iteration for better performance"

The attached patch tries to perform similar operations as other parts
introduced in the above commits to fix the functions causing the segfaults.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.